If a product attribute value can't be casted to a string, try to repr…

[hostep]

…esent it as json data. This fixes crashing the product edit page when using different tier prices over multiple websites for example.

This fixes https://github.com/avstudnitz/AvS_ScopeHint2/issues/13 and is a replacement for another proposed PR: https://github.com/avstudnitz/AvS_ScopeHint2/pull/15

Steps to reproduce the original reported problem:

• Setup a vanilla Magento installation (tested both on 2.1.16 and 2.3.2)
• Install avstudnitz/scopehint2 v1.1.1
• In the configuration, go to Catalog > Catalog > Price
• Change 'Catalog Price Scope' to 'Website'
• Go to Stores > All Stores and make sure you have a least 2 websites, stores & store views
• Create a new product, assign it to all the websites and setup tier prices (under 'Advanced Pricing')
• Switch to the other storeview scope associated with the second website
• Setup different tier prices on that scope
• See the page crashing without this fix

The reason why it crashes, is because the tier prices are returned as an array instead of the expected string. We've seen a similar problem with a third party module, which also returns an array, but a multi dimensional one. The original attempt to fix this tried to implode the value if it was an array, but that won't work on a multi dimensional array.

This PR attempt to fix all of these possible scenario's.

I've chosen a slightly different approach here, because I think there might be more than only array types not being able to get casted to a string. Here I'm trying to cast the value to a string in a try-catch statement, if this fails, the \Throwable will get catched and the error won't appear on the frontend. If this happens, I'm trying to json_encode the value, to get a string representation of the value. If that still fails, we silently ignore the problem and won't output anything.

In the case of the tier prices problem, there is another bug in that the tooltip doesn't show up for some reason. I haven't looked why that that happens yet, but that should be considered a different bug. This PR is trying make the product edit page more stable, I prefer to have it not crashing over showing the correct tooltip. Fixing the tooltip can be done at a later stage in my opinion.

If there are remarks, let me know! 🙂

[avstudnitz]

Thanks a lot!

[hostep]

Awesome, thanks for merging so quickly!

Any chance you can also tag a new version? 🙂

(and PR https://github.com/avstudnitz/AvS_ScopeHint2/pull/15 can be closed now I believe)