search

avto-dev / roadrunner-laravel

[ABANDONED] Moved to https://github.com/spiral/roadrunner-laravel
MIT License
120 stars 15 forks source link

customized header data remains dirty #18

Closed littlexiang closed 5 years ago

littlexiang commented 5 years ago

Describe the bug

request header bag will keep previous data

Expected behaviour

refresh header every request

Actual behaviour

WARN[0086] [2019-08-26 12:01:56] local.DEBUG: request->header DEVICE-ID: a0168a20-2ec7-42ae-817e-5e6db44c2122 WARN[0086] [2019-08-26 12:01:56] local.DEBUG: request->headers->get DEVICE-ID: ad456c85-caf9-4e33-bd20-88139973a2d3

$request->headers['devide-id'] gets the latest value while $request->headers->get('devide-id') remains dirty

System information

PHP 7.3.8 Laravel 5.8 RoadRunner-Laravel: ^2.0.0

littlexiang commented 5 years ago

I assume it's because I did this in BaseController public function __construct(Request $request) { $this->request = $request; } So I have to add --refresh-app

tarampampam commented 5 years ago

You should avoid to use controller constructor for dependencies resolving (instead of this you can request all dependencies in controller method signature or use request() helper).

Can I close this issue?

tarampampam commented 5 years ago

ping @littlexiang