search

avuserow / amp

Acoustics Media Player - network jukebox
Other
26 stars 5 forks source link

Amp blows up when you do things 2.0 Special Edition #59

Closed klange closed 13 years ago

klange commented 13 years ago

When the player is not running and I hit "stop", a very fun thing happens under my CGI server: We get signal, and then bombs are set us up, etc. Basically, Amp is sending a signal to the underlying server when the player isn't running, and that signal kills the server (cleanly, as the server itself catches the SIGINT that it is receiving).

My configuration: Local/sqlite/MPlayer, custom CGI server What I did: Pressed stop when the player wasn't running. What I expected to happen: Absolutely nothing. What actually happened: BOOM

Proposed fix: Actually determine whether the player is running before throwing signals around.

avuserow commented 13 years ago

If you are going to file bugs with your own server, we need its code. Otherwise, reproduce under Apache (or another supported webserver, if we have one?)

klange commented 13 years ago

Fixed. We were sending signals to process "0", so we were killing ourselves, which in turn killed quite a bit more. We shouldn't have been doing that anyway.