search

avvo / docker-ruby

Our base ruby image. Do not use the image, see https://github.com/avvo/docker-base instead
4 stars 1 forks source link

Add ruby-irb alpine package #4

Closed chingor13 closed 7 years ago

chingor13 commented 8 years ago

This will install ruby-irb into our base ruby images so that you can run rails console in the container.

remkade commented 7 years ago

I would argue that we should leave this out, and just document how to install this package in the case of debugging.

I'd prefer to err on the side of lean personally.

dplummer commented 7 years ago

I agree. If someone needs to run a console command they can probably just run apk add ruby-irb

bluetwin commented 7 years ago

I feel this could be more helpful if we make this simple instead of having to install ruby-irb to debug. @dplummer how do you handle debugging in Elixir?

sringling commented 7 years ago

@dplummer @remkade I'd like to see this happen - apk add is a command we have to memorize and enter every time we want to rails c something and this makes it simpler. Do you really want to tell every single current and future employee they should memorize that command and enter it in every single time they need to debug anything ever in any rancher instance? Is there a concrete size metric that is bothersome about the inclusion of this library?

remkade commented 7 years ago

We should be able to have a message of the day printed by the shell when you login.

The size of the container directly impacts production deployment time and sometimes reliability. I'd rather forgo a library that is used occasionally for debugging if we can simply have a helpful motd explaining basic debugging stuff (which we should add either way).

On Jan 9, 2017 10:45 AM, "Seth Ringling" notifications@github.com wrote:

@dplummer https://github.com/dplummer @remkade https://github.com/remkade I'd like to see this happen - apk add is a command we have to memorize and enter every time we want to rails c something and this makes it simpler. Do you really want to tell every single current and future employee they should memorize that command and enter it in every single time they need to debug anything ever in any rancher instance? Is there a concrete size metric that is bothersome about the inclusion of this library?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/avvo/docker-ruby/pull/4#issuecomment-271368700, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgahSpr_7f_dO7KhHcdR4BTwCZnnwV3ks5rQoBRgaJpZM4Kp57v .

dplummer commented 7 years ago

+1 for motd, that's a great idea

@bluetwin: for Elixir the compiled binary includes the console, so (for say StrangerForces) you can run ./app/bin/stranger_forces console to get the repl. Since its a compiled image it isn't possible to add the console later. Fortunately due to the compiling process we use our docker images are ~30MB for Elixir projects :)