Parse untranslated `wx_codes` into `other` - Githubissues

avwx-rest / avwx-engine

Aviation Weather parsing engine. METAR & TAF

MIT License

90 stars 31 forks source link

Parse untranslated `wx_codes` into `other` #53

Closed NickGlauberCirium closed 1 year ago

NickGlauberCirium commented 1 year ago

Description

Updates avwx.current.base.wx_code() to return the code unmodified if it contains no strings that are in avwx.static.core.WX_TRANSLATIONS.

This causes directional visibility and some other random tokens to end up in other rather than wx_codes.

Some example tokens from METAR reports that previously were parsed into wx_codes and are now parsed into other with this change:

Directional visibility token 0800SE from report EGJB 011850Z 20012KT 1200 0800SE -RADZ BCFG BR SCT000 BKN001 16/16 Q1003 RERA REDZ
Cloud Movement? token CB(SE-N) from report GBYD 291500Z 25006KT 9000 -RA BKN011 FEW018CB SCT110 26/25 Q101 1 CB(SE-N)

Checklist

[x] Tests covering the new functionality have been added
[x] Documentation has been updated OR the change is too minor to be documented
[x] Changes are listed in the CHANGELOG.md OR changes are insignificant