Rows automatically adjusting height

awSweeney / FFXIV-ACT-Rainbow-Mage-Overlays

Overlay skins for Advanced Combat Tracker (ACT) FFXIV Parsing Plugin

GNU General Public License v3.0

13 stars 10 forks source link

Rows automatically adjusting height #6

Closed PrymeWolf closed 2 years ago

PrymeWolf commented 2 years ago

On the overlay, depending on the jobs the height of the rows are different. I've noticed this on WHM, SGE, RPR, SCH and some others to be different height.

awSweeney commented 2 years ago

Issue confirmed and reproduced.

Appears to be a result of the SCH icon being an incorrect size. NIN and SMN icons found to be a couple pixels off as well. Adjusting icons to 32x32.

Updates to be tested on the Endwalker branch.

PrymeWolf commented 2 years ago

upon changing the pixels to 32x32, the SCH icons specifically looks very distorted and enlarged.

awSweeney commented 2 years ago

Sch icon adjusted further.

dfaabad1b8

PrymeWolf commented 2 years ago

Maybe it's just me, but do you know why my rows are still different heights?

awSweeney commented 2 years ago

In this scenario it may be due to the broken image link. I noticed this has started popping up since Endwalker when it cannot find the correct entity. I opened a separate issue and currently testing out a solution.

Do you recall what class Mituking was on during this encounter? I have not seen the broken link occur for any of the player classes. Usually it has been limited to NPC entities.

PrymeWolf commented 2 years ago

I believe Mituking was playing RDM.　Sorry, to add. The different heights occur with/without the broken link image.

Thalassocrat commented 2 years ago

Also getting thicker rows than usual or than the sample pictures on this page. Just thought I'd add an example. Thanks for the overlay! https://puu.sh/IveEr/743614cb69.png

awSweeney commented 2 years ago

Thanks Thalassocrat. That helps confirm it's not an isolated issue. Will get to the bottom of it, unfortunately the long queues are causing delays in dev/testing. Thanks for your patience :)

awSweeney commented 2 years ago

@Thalassocrat and @PrymeWolf I pushed an update to the Endwalker branch, setting the bars to a fixed height. Can you see if it makes a difference for you?

Thalassocrat commented 2 years ago

I'm sorry it's still the same for me.

awSweeney commented 2 years ago

It would seem the styles are being ignored.

Just to confirm:

Try doing a fresh install, deleting the previous version and starting with a fresh directory.
The new downloaded zip file reads FFXIV-ACT-Rainbow-Mage-Overlays-Endwalker-v1.1.1.zip or FFXIV-ACT-Rainbow-Mage-Overlays-Endwalker-Updates.zip
The theme selected in ACT is {Install-Dir}/FFXIV-ACT-Rainbow-Mage-Overlays/overlays/MiniParseGlow_CritMonitor_Classic.html
The DLL files included in the ACT Overlay Plugin are unblocked as outlined in ReadMe step number 2
Running ACT as admin and on the latest version
What OS are you running on Windows 10/11, Mac?

awSweeney commented 2 years ago

@dconns1 mind poking around and see if you can recreate on your side?

Thalassocrat commented 2 years ago

It is the most fixed, thank you SO much for your overlay and time. It is great, and very appreciated.

awSweeney commented 2 years ago

Excellent. Thank you for your patience and communication. I will mark this as resolved. If anything else pops up please feel free to open a new issue.

Prymewolf I saw a brief comment asking about customization and that it was resolved for you also. The styles were moved under the CSS folder. You should be able to customize as before by modifying there. I had moved things around a bit to be able to add some new overlays in the future.

awSweeney commented 2 years ago

Resolved under v1.1.1