awakesecurity / gRPC-haskell

Haskell gRPC support
https://hackage.haskell.org/package/grpc-haskell
Apache License 2.0
238 stars 75 forks source link

Make server process killable #105

Closed Gabriella439 closed 4 years ago

Gabriella439 commented 4 years ago

https://github.com/awakesecurity/gRPC-haskell/commit/35163c3c1861f2eb27ea443dac20a4960d76d87d introduced a new use of mask which makes the server process uninterruptible while waiting for a new incoming request. This change fixes that by surrounding the logic that waits for a new request with unmask. This new unmask should still respect the finalization guarantees of the surrounding masked code.