awakesecurity / gRPC-haskell

Haskell gRPC support
https://hackage.haskell.org/package/grpc-haskell
Apache License 2.0
238 stars 75 forks source link

Fix cabal build with-examples #112

Closed greglaun-google closed 3 years ago

greglaun-google commented 3 years ago

I'm unable to build the examples from master on a stock Ubuntu VM. I'm building using cabal rather than stack.

Most recently, the build was broken by PR #110, which upgraded proto3-wire and proto3-suite.

The version released on Hackage (https://hackage.haskell.org/package/grpc-haskell) also fails to build.

Steps to reproduce:

  1. Grab an Ubuntu Groovy VM
  2. Run 'sudo apt-get update`
  3. Install Nix following https://nixos.org/download.html
  4. git clone https://github.com/awakesecurity/gRPC-haskell.git
  5. Run nix-shell release.nix -A grpc-haskell.env, which succeeds.
  6. Run cabal configure --enable-tests && cabal build && cabal test, which succeeds.
  7. Finally, run cabal configure --enable-tests -f with-examples && cabal build && cabal test

Expected result: Build succeeds.

Actual result:

build fails with an error "The constructor ‘ServiceOptions’ should have 9 arguments, but has been given 8."

Gabriella439 commented 3 years ago

Fix is up here: https://github.com/awakesecurity/gRPC-haskell/pull/115