search

awakesecurity / gRPC-haskell

Haskell gRPC support
https://hackage.haskell.org/package/grpc-haskell
Apache License 2.0
238 stars 75 forks source link

install-macos-nix-grpc: link libgpr too #143

Closed fumieval closed 1 year ago

fumieval commented 1 year ago

This is needed to build grpc-haskell on my environment

riz0id commented 1 year ago

Thank you!

ixmatus commented 1 year ago

For a reason I cannot divine, the test suite appears to diverge on the macos tester...

riz0id commented 1 year ago

@fumieval are you using Nix to build grpc-haskell? If so, I believe #145 will fix the linking problems you're encountering when building grpc-haskell from within a Nix shell.

fumieval commented 1 year ago

No I'm not; I was simply trying to build it with plain cabal-install and --extra-lib-dirs

fumieval commented 1 year ago

By linking, I mean creating a symbolic link to libgpr.dylib

fumieval commented 1 year ago

@riz0id @ixmatus Is there anything I should do here? Is the build failure on Mac a blocker?

ixmatus commented 1 year ago

@fumieval we're pretty bogged down ATM and haven't had time to look at this. I don't think this is a blocker but something has happened recently causing the test to diverge on GitHub Action's macos builder.

fumieval commented 1 year ago

@ixmatus I understand your situation, but this is merely a one-line change to link libgpr.dylib. It doesn't affect anything but those who run bin/install-macos-nix-grpc.sh locally, so it would be nice if you could take a look and merge this.