search

awakesecurity / gRPC-haskell

Haskell gRPC support
https://hackage.haskell.org/package/grpc-haskell
Apache License 2.0
238 stars 75 forks source link

Rebase fix memory leak #153

Closed fumieval closed 1 year ago

fumieval commented 1 year ago

This is the same as #140 but rebased on master

riz0id commented 1 year ago

@fumieval This should be good to go, but you need to make sure you rebase on main after https://github.com/awakesecurity/gRPC-haskell/commit/414ae8e6612e8e28d2bcfb6e201303f5fc031e5a in order for MacOS to pass in CI.

riz0id commented 1 year ago

OSX is hanging indefinitely on the test suite. This is happened before and I thought I disabled testing because of this, so I don't know why its happening. Looking into it right now.

ixmatus commented 1 year ago

Going ahead and merging because the macos test divergence is known and @riz0id has verified this change fixes memory leaks while not breaking anything (so far as we know).

ixmatus commented 1 year ago

@fumieval thank you for your contribution!

riz0id commented 1 year ago

Thank you so much for the change @fumieval its a really great improvement. Sorry it took me so long to get around to reviewing it.

fumieval commented 1 year ago

@ixmatus @riz0id Well, I merely rebased @mrBliss's work so the credit goes to him. This is a great improvement indeed

riz0id commented 1 year ago

Right, sorry. Thank you @mrBliss !

ixmatus commented 1 year ago

Oops, thank you for the correction @fumieval. We appreciate the work you did to rebase and help us move @mrBliss's contribution along!