search

awakesecurity / gRPC-haskell

Haskell gRPC support
https://hackage.haskell.org/package/grpc-haskell
Apache License 2.0
238 stars 75 forks source link

Grpc 1.45+ support #157

Closed jsoo1 closed 11 months ago

paulbrauner-da commented 11 months ago

Hello, I was working on a similar change on my side but couldn't get the nix bits to work. If I understand your PR correctly, after this change the gRCP-haskell library won't let you create insecure connections anymore.

I think there is a way to preserve the existing API, which allows to create insecure connections. The grpc C library lets you create insecure credentials, which you can then pass to grpcChannelCreate in the case where clientSSLConfig is Nothing.

jsoo1 commented 11 months ago

Oh hey! Thanks for the tip! I think that should push this over the line!

paulbrauner-da commented 11 months ago

Thanks a lot, @jsoo1!