Closed cocreature closed 5 years ago
@cocreature thank you for doing this, my first comment is the only one I have that I think should be addressed.
I'm verifying this branch works on my own laptop in a nix-shell before merging this.
@ixmatus I’ve addressed your first commend about the dojailbreak
thing by simply bumping the rev now that you’ve merged my PR (thanks for that!)
I've confirmed that I can build this on my laptop in a nix-shell
and with nix-build
. I've also verified the nix-shell environment and nix-build on our primary Linux build node.
This is a continuation of #80. The tests are passing locally for me on both Linux and MacOS.