Upgrade to gRPC 1.22 - Githubissues

cocreature commented 5 years ago

I’ve tested this both on Linux and MacOS and the tests pass.

ixmatus commented 5 years ago

I have a busy day today and will try to review this PR later this evening, tomorrrow at the latest (though one of my colleagues may review before I can). @cocreature thank you for the contribution!

cocreature commented 5 years ago

@ixmatus Take your time, it’s not urgent :slightly_smiling_face:

Gabriella439 commented 5 years ago

@ixmatus: As a rule of thumb, I recommend to not block on more than one review. If somebody has objections to how things are done they can always open a new pull request to fix things.

The reason I suggest doing things this way is that:

(A) You want the pull request process to reward those who take initiative improve things and author contributions (as opposed to those who only react to changes)
(B) It creates a high-trust environment where people trust each other to act more autonomously instead of waiting for the "right" person to review the change

ixmatus commented 5 years ago

@Gabriel439 that seems reasonable to me.

awakesecurity / gRPC-haskell

Upgrade to gRPC 1.22 #85