search

awakesecurity / gRPC-haskell

Haskell gRPC support
https://hackage.haskell.org/package/grpc-haskell
Apache License 2.0
238 stars 75 forks source link

Don’t free op array values in op_array_destroy #98

Closed cocreature closed 4 years ago

cocreature commented 4 years ago

These values are all already freed in freeOpContext and doing it twice is an error, see #91

I’ve gone through the four kinds of frees here and afaict all of them are already handled by freeOpContext.

This fixes #91, cc @neongreen

neongreen commented 4 years ago

Will try out locally.

neongreen commented 4 years ago

Works for me.

neongreen commented 4 years ago

@Gabriel439 do you have plans to test this on the awakesecurity codebase? Because if not, I guess this can just be merged.

Gabriella439 commented 4 years ago

@neongreen: Whoops! Sorry for the delay. You don't need to block on us to merge things. If we run into any issues when we update our code to use this we will upstream any fixes we need