awakesecurity / proto3-suite

Haskell Protobuf Implementation
https://hackage.haskell.org/package/proto3-suite
Other
80 stars 55 forks source link

Fix parsing and pretty-printing of string literals #220

Closed Gabriella439 closed 2 years ago

Gabriella439 commented 2 years ago

While debugging the test failure on #218 I realized that the logic for parsing and pretty-printing import paths was broken in several ways:

… so I fixed this

Fixes #218

Gabriella439 commented 2 years ago

I had to remove a few tests which were broken. The root cause was that the proto3 parser was silently ignoring the rest of the file when hitting an invalid parse instead of failing. This PR fixed that (by requiring the parser to match eof when it's done), but then unearthed some invalid proto3 files in the test suite, which I had to delete (along with their reverse dependencies).

j6carey commented 2 years ago

Thanks!

Gabriella439 commented 2 years ago

You're welcome!