search

awalsh128 / cache-apt-pkgs-action

Cache APT packages in GitHub Actions
Other
205 stars 35 forks source link

Don't install apt-fast from source #96

Closed pascallj closed 1 year ago

pascallj commented 1 year ago

There is no reason to install apt-fast from source as it is already included in all of the Ubuntu runner images.

awalsh128 commented 1 year ago

Thank you!

mstruebing commented 1 year ago

Hey there, we were just testing your action but we are using custom runners with custom runner images. That being said, would you be open to an extra argument to that action that would install apt-fast from the source if present as our runner images don't have these preinstalled?

If you like that idea, I would try to make a PR with that change.

pascallj commented 1 year ago

You're right, custom runners are also a thing. There is no need to implement an extra argument for that. We can easily detect if apt-fast is present and executable. I've created PR #97 to address this.