deriveEqual: Use Equal() if it is defined on T

[gpaul]

I would like to generate deriveEqual for the following type hierarchy:

type Foo struct {
    Field Bar
}

func (this *Foo) Equal(that *Foo) bool {
    return deriveEqual(this, that)
}

type Bar map[string]interface{}

Now, as it is not possible to derive an Equal for an interface{} this fails. However, I would like to implement func (Bar) Equal(other Bar) bool {} myself and have deriveEqual notice that and call it instead.

That way I can take responsibility for the fact that I end up calling reflect.DeepEqual() or implementing custom Equal logic lower down my type hierarchy while still benefiting from all the lovely code generation for the rest of it.

[awalterschulze]

goderive does some check for equal methods on structs, but maybe goderive could do checks on other types as well. I'll look into making sure this works.

[awalterschulze]

Should work now https://github.com/awalterschulze/goderive/commit/77a50e43e09d55ef12d439668ef3712369272bde

[gpaul]

Wow that was fast, thank you! Works like a charm.

[awalterschulze]

My pleasure :) It was an easy fix.

If you are using it in some project, we would love to add that project to your users list, if possible?

[gpaul]

Sigh for the moment it is closed source, sorry. We plan on open sourcing part of it in the next few months though.

[awalterschulze]

No problem. Just trying my luck :)

[gpaul]

If you're happy with just "used by XXX" then I'll let you know once we release the closed source version, right now the project is in early development.

[awalterschulze]

Also happy to add used by XXX with a link to the closed source project.

[sakeven]

@awalterschulze Hi, I think we should use Equal() before using “==” if Equal is defined for T. This is because if T changes, we can’t use “==” and it may only be equal through Equal().

[awalterschulze]

Would you like to create a new issue with a more elaborate description, I don't think I fully understand