search

awalterschulze / goderive

Derives and generates mundane golang functions that you do not want to maintain yourself
Apache License 2.0
1.24k stars 43 forks source link

defer file.Close #78

Closed OladapoAjala closed 2 years ago

OladapoAjala commented 2 years ago

Closes #25

awalterschulze commented 2 years ago

This is a vendored dependency, so we ideally do not want to modify it.

The idea of the defer.Close issue, is to create a plugin that generates some code that would, make it easy to properly handle closing files and the errors better than defer does, but just as conveniently, not fix the issues we have.

Fixing how we handle file.Close is on table though, but not to close the issue, simply to make our code more reliable.

awalterschulze commented 2 years ago

Sorry about the confusion, the issue isn't described very clearly

OladapoAjala commented 2 years ago

No worries, I think the goal to effectively work on the open issues and have them closed ASAP so helping clarify open issues suffices too.