search

awalterschulze / gominikanren

a Go implementation of miniKanren, an embedded Domain Specific Language for logic programming.
Other
38 stars 2 forks source link

make travis, updating gocc #20

Closed deosjr closed 2 years ago

deosjr commented 2 years ago

As per https://github.com/awalterschulze/gominikanren/pull/19#issuecomment-1102700839

deosjr commented 2 years ago

Perhaps I misunderstand, but seems to me that running git diff --exit-code . in make travis will throw an error on any changes ever? That doesn't seem helpful.

awalterschulze commented 2 years ago

The idea is that all generated code is checked in

I wonder if make travis uses the locked versions? Or simply the newest code. Maybe it is possible to make it use the locked versions?

On Thu, 12 May 2022 at 18:53, Sjoerd Dost @.***> wrote:

Perhaps I misunderstand, but seems to me that running git diff --exit-code . in make travis will throw an error on any changes ever? That doesn't seem helpful.

— Reply to this email directly, view it on GitHub https://github.com/awalterschulze/gominikanren/pull/20#issuecomment-1125271523, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAN6YLJV4LBR2NDIICHIRHDVJVASJANCNFSM5VZAIPYQ . You are receiving this because your review was requested.Message ID: @.***>

deosjr commented 2 years ago

go get doesnt reinstall, so I was running an old version of gocc locally ;) fixed

awalterschulze commented 2 years ago

Maybe we could rename travis to ci or something more generic in the Makefile, but we could do that in a follow up diff. Thanks for fixing this it looks great :D