search

awamper / wikipedia-search-provider

GNOME Shell extension. Wikipedia Search Provider.
https://extensions.gnome.org/extension/512/wikipedia-search-provider/
42 stars 9 forks source link

Undefined properties and variables in JavaScript code #16

Open Edenhofer opened 7 years ago

Edenhofer commented 7 years ago

Some variables are not properly declared in JavaScript and GNOME therefore logs some undesirable warnings. Excerpt from journalctl:

DATE MachineName gnome-shell[6715]: JS WARNING: [/home/username/.local/share/gnome-shell/extensions/wikipedia_search_provider@awamper.gmail.com/extension.js 376]: reference to undefined property Shell.ActionMode.MESSAGE_TRAY
DATE MachineName gnome-shell[6715]: JS WARNING: [/home/username/.local/share/gnome-shell/extensions/wikipedia_search_provider@awamper.gmail.com/wikipedia_result_view.js 146]: reference to undefined property this._wikipedia_page.url
DATE MachineName gnome-shell[6715]: JS WARNING: [/home/username/.local/share/gnome-shell/extensions/wikipedia_search_provider@awamper.gmail.com/wikipedia_page.js 233]: reference to undefined property pageprops.page_image
DATE MachineName gnome-shell[6715]: JS WARNING: [/home/username/.local/share/gnome-shell/extensions/wikipedia_search_provider@awamper.gmail.com/wikipedia_page.js 126]: reference to undefined property page_data.images
DATE MachineName gnome-shell[6715]: JS WARNING: [/home/username/.local/share/gnome-shell/extensions/wikipedia_search_provider@awamper.gmail.com/extension.js 311]: assignment to undeclared variable x
DATE MachineName gnome-shell[6715]: JS WARNING: [/home/username/.local/share/gnome-shell/extensions/wikipedia_search_provider@awamper.gmail.com/extension.js 311]: assignment to undeclared variable y

I am using gnome-shell version 3.24.2, Linux version 4.11.5 and X as window system. The extension version is the one which is currently available at http://extensions.gnome.org.