search

awamper / wikipedia-search-provider

GNOME Shell extension. Wikipedia Search Provider.
https://extensions.gnome.org/extension/512/wikipedia-search-provider/
42 stars 9 forks source link

Works in 3.10 but can't open configuration #5

Closed mightymouse2045 closed 10 years ago

mightymouse2045 commented 10 years ago

Get this error when trying to configure:

TypeError: this._store.set is not a function

Stack trace: WikipediaKeybindingsWidget<._refresh@/home/ph/.local/share/gnome-shell/extensions/wikipedia_search_provider@awamper.gmail.com/prefs.js:162 wrapper@/usr/share/gjs-1.0/lang.js:213 WikipediaKeybindingsWidget<._init@/home/ph/.local/share/gnome-shell/extensions/wikipedia_search_provider@awamper.gmail.com/prefs.js:139 wrapper@/usr/share/gjs-1.0/lang.js:213 WikipediaSearchProviderPrefsWidget<._get_keybindings_page@/home/ph/.local/share/gnome-shell/extensions/wikipedia_search_provider@awamper.gmail.com/prefs.js:466 wrapper@/usr/share/gjs-1.0/lang.js:213 WikipediaSearchProviderPrefsWidget<._init@/home/ph/.local/share/gnome-shell/extensions/wikipedia_search_provider@awamper.gmail.com/prefs.js:269 wrapper@/usr/share/gjs-1.0/lang.js:213 buildPrefsWidget@/home/ph/.local/share/gnome-shell/extensions/wikipedia_search_provider@awamper.gmail.com/prefs.js:479 Application<._selectExtension@/usr/share/gnome-shell/js/extensionPrefs/main.js:100 wrapper@/usr/share/gjs-1.0/lang.js:213 Application<._extensionsLoaded@/usr/share/gnome-shell/js/extensionPrefs/main.js:219 wrapper@/usr/share/gjs-1.0/lang.js:213 _emit@/usr/share/gjs-1.0/signals.js:124 ExtensionFinder<._extensionsLoaded@/usr/share/gnome-shell/js/misc/extensionUtils.js:178 wrapper@/usr/share/gjs-1.0/lang.js:213 done@/usr/share/gnome-shell/js/misc/fileUtils.js:33 @/usr/share/gnome-shell/js/misc/fileUtils.js:51 onNextFileComplete@/usr/share/gnome-shell/js/misc/fileUtils.js:21 main@/usr/share/gnome-shell/js/extensionPrefs/main.js:276 @:1

awamper commented 10 years ago

I can’t reproduce it. What distribution are you using? Gtk version?

Try commenting out lines 269, 281 in the file "/home/ph/.local/share/gnome-shell/extensions/wikipediasearch_provider@awamper.gmail.com/prefs.js"

mightymouse2045 commented 10 years ago

Using gnome-shell 3.10.2 on Ubuntu gnome 14.04 GTK version 3.11.2

Commenting out those lines works and allows me to get to the config. What are those 2 lines doing?

awamper commented 10 years ago

shortcuts settings

mightymouse2045 commented 10 years ago

Like searching with w then the search? Because that's working still and also if I change the key it works as well

awamper commented 10 years ago

No. Searching from the clipboard and primary selection with keyboard shortcuts (Super-w, Super-Shift-w). These two lines showed a widget to change this shortcuts.

mightymouse2045 commented 10 years ago

ah ok - so what gtk version is made for?

awamper commented 10 years ago

I tested it only with 3.10.

mightymouse2045 commented 10 years ago

must be the new gtk version in 14.04 then on ubuntu

mightymouse2045 commented 10 years ago

yep nice one - works perfectly :)

mightymouse2045 commented 10 years ago

Sorry I closed in haste - the searches are overlapping each other now... even if I comment out those 2 lines in prefs.js...

mightymouse2045 commented 10 years ago

so the search box from column 1 is overlapping the search in column 2 - they aren't wrapping the text or something along those lines?

awamper commented 10 years ago

yep nice one - works perfectly :)

what works perfectly? I have not done anything for this bug.

awamper commented 10 years ago

overlapping fixed.

mightymouse2045 commented 10 years ago

Strange I did I git pull when i saw another email from you and there were 2 updates. Then the shortcut settings started working, so I thought that was what you fixed :p

So both those things are working for me now, the shortcut settings, and the overlapping has disappeared again