search

awapps / mongration

MongoDB migration framework
MIT License
85 stars 24 forks source link

Use filename as id instead of have it inside migration script #12

Closed marcusberro closed 8 years ago

marcusberro commented 8 years ago

Would be good to have filename as step id instead of an id written by developer

wmartins commented 8 years ago

@marcusberro what do you think to have both file name and developer id in migration persisted object?

What do you think @eberhara?

marcusberro commented 8 years ago

@wmartins @eberhara I've experienced some mistakes using Mongration with more than one migration scripts. For example, when you have similar scripts that you copy and rename the file, developers can forget to change the id. I guess that would be great to constraint the id just on filename and I'm not sure if it is a good idea to keep both option.

eberhara commented 8 years ago

Closing since we agreed that assuming a step id by its file name is not a good practice.