awapps / mongration

MongoDB migration framework
MIT License
85 stars 24 forks source link

Updated the mongodb dependency to support mongo 3.4 with auth #34

Closed Sh33pman closed 7 years ago

Sh33pman commented 7 years ago

Currently when using the library with mongodb 3.4 that has authentication enabled on it, the migration process fails. Updated mongodb to version 2.2.25. This fixes the issue when trying to run the migrations 3.4 with auth.

wmartins commented 7 years ago

Looks good to me @Sh33pman! Thank you for that!

What do you think @eberhara?

Sh33pman commented 7 years ago

It's a pleasure to help.

abondoa commented 7 years ago

Looking forward to this. Is there an ETA on it? I guess a work-around is to shrinkwrap, although I have not tried yet.

Just started using mongration recently and it works like a charm locally, but not so much on our staging with auth :)

eberhara commented 7 years ago

@Sh33pman @abondoa - I just merged it into master and published to npm as mongration@1.0.0

abondoa commented 7 years ago

@eberhara Sweet!

We discovered problem about using ssl cert, privatekey, and CA in the connection (or any other mongodb option). There does not seem to be a way to pass that into the migrations.

My colleague made a fork to try and solve this. We will make another pull request for it, but you can have a look: https://github.com/razvanc92/mongration/tree/connection-options

wmartins commented 7 years ago

Hey @abondoa, it would be nice if you provide us a way to reproduce the same issue you guys have!

You can also open an issue here with that.