search

away3d / away3d-core-fp11

Away3D engine for Flash Player 11
http://www.away3d.com
Other
639 stars 274 forks source link

AWD2Parser ignores the "loop" property for SkeletonAnimation #707

Open liaocheng opened 10 years ago

liaocheng commented 10 years ago

See this code in parseSkeletonAnimation function:

 parseProperties(null); // Ignore properties for now

But the same process is done for VertexAnimation. See parseMeshPoseAnimation function:

props = parseProperties({1:BOOL, 2:BOOL});

clip.looping = props.get(1, true);
clip.stitchFinalFrame = props.get(2, false);

Should we add the same code to parseSkeletonAnimation as well?

80prozent commented 10 years ago

Hey

Thank you for testing. Yes. your suggestion is correct. The parsing of the properties should be the same for SkeleteonAnimation, as we have for MeshPoseAnimation.

I was used to commit to the dev-branch, but with the refactor for 4.1 going on, i will talk to Sergey/Rob which branch i should push fixes to (master-branch / 4.1Dev-branch).