search

awcodes / filament-curator

A media picker plugin for Filament Panels.
MIT License
298 stars 79 forks source link

Add `should_check_visibility` config to allow circumventing Storage disk operations #472

Closed Log1x closed 2 months ago

Log1x commented 2 months ago

I brought this up in Discord awhile back but was a little late on getting a PR in.

This adds a should_check_visibility config to allow bypassing the Storage::exists() and Storage::getVisibility() checks when fetching a media URL.

These operations are seemingly quite intensive when media is stored in an S3 bucket.

Not 100% sold on the config key name – if you have a better idea, feel free.

awcodes commented 2 months ago

I'm ok with this.

Can you change the config key to 'should_check_exists', don't want it to get confused with the actual 'visibility' settings.

awcodes commented 2 months ago

Thank you. :)