search

awcodes / filament-curator

A media picker plugin for Filament Panels.
MIT License
324 stars 86 forks source link

Media Resource List Page #487

Closed onairmarc closed 4 months ago

onairmarc commented 4 months ago

Filament Version

v3.2.81

Plugin Version

v3.5.8

PHP Version

8.3

Problem description

When viewing Media Resource List page, the images are not aligned with the check box container and are not clickable from the image nor the checkbox. I doubled checked my theme files just to make sure I didn't do anything incorrectly and it appears that everything is in working order there.

In a last ditch attempt, I revered to v3.5.7 to see if that resolved the issue and it did. I'm not sure what changed in v3.5.8, but it appears to be a breaking change regarding displays and interactions.

Expected behavior

The image should be clickable from the resource list page. It is not.

Steps to reproduce

Upgrade to v3.5.8 from v3.5.7. The issue appears automatically.

Reproduction repository

No response

Relevant log output

No response

onairmarc commented 4 months ago

Screenshot_05-21-24_0314PM

awcodes commented 4 months ago

Rebuild your theme. npm run build

awcodes commented 4 months ago

Might need a artisan filament:assets first though.

onairmarc commented 4 months ago

I should have time this weekend to dive into this. Right now we're pinned at v3.5.7 until I get time to debug.

onairmarc commented 4 months ago

I mistakenly published the curator views when I was trying something and forgot to delete them. I was conditionally showing details based on permissions. I guess there was some change between the version I published and the most recent updates. Deleting the views that shouldn't have been committed fixed this issue.

This was most definitely a skill issue on my end.