search

awcodes / filament-curator

A media picker plugin for Filament Panels.
MIT License
343 stars 89 forks source link

Ensure curation visibility matches original image #526

Closed dgoetzit closed 3 months ago

dgoetzit commented 3 months ago

Hello @awcodes!

I was wondering if you thought this implementation would make sense to ensure that curations always have the same visibility as the original image they are a curation of.

Although Curations are saved into the media table with the same visibility of their original image, when using some S3 compatible storage options (Digital Ocean Spaces specifically 😮‍💨), all resources are created as private unless otherwise specified. This results in them showing as public per the Media/Curation record, but actually existing as private since visibility was not specified.

This would fix that issue, and ensure that the functionality remains the same for everyone else who may be able to configure default visibility on a bucket differently.

awcodes commented 3 months ago

Thanks for the PR. This seems reasonable to me. Will test further and merge soon.