search

awcodes / filament-tiptap-editor

A Rich Text Editor plugin for Filament Forms.
MIT License
272 stars 73 forks source link

Feat: support relative media paths via config #193

Closed awcodes closed 10 months ago

robin-dongbin commented 10 months ago

So you realize the problem yourself now? Just opinionated. https://github.com/awcodes/filament-tiptap-editor/pull/133

awcodes commented 10 months ago

This has nothing to do with your previous PR. But if it makes you feel better about yourself then sure you were right.

robin-dongbin commented 10 months ago

My previous PR is because I want to use relative media path https://github.com/awcodes/filament-tiptap-editor/pull/133#issuecomment-1626600552

awcodes commented 10 months ago

I'm not going to do this with you. You're PR didn't solve the issue and was therefore not merged. You can now use your relative urls. Please feel free to write you're own plugin and do what ever you want with it. But there is zero need to bring your closed Pr into this at this time.

Nestoran commented 7 months ago

Would you please implement this relative path support into v2?

awcodes commented 7 months ago

I'm open to a PR for it, but have no plans to back port features into previous versions.