awcodes / filament-tiptap-editor

A Rich Text Editor plugin for Filament Forms.
MIT License
249 stars 64 forks source link

Not working in Modals Anymore #369

Closed AlexisSerneels closed 1 month ago

AlexisSerneels commented 2 months ago

Filament Version

v.3.2.70

Plugin Version

v.3.3.2

PHP Version

PHP 8.2

Problem description

Since this release : https://github.com/awcodes/filament-tiptap-editor/releases/tag/v3.3.0, this.editor() is underfinedis returned when trying to insert a link, or add a media, etc. This happens for me when using the editor with an Modal from a RelationManager.

Reverting to v3.2.27 fixes the issue.

CleanShot 2024-04-19 at 09 42 13@2x

Expected behavior

We expect to be able to insert an image

Steps to reproduce

Reproduction repository

No response

Relevant log output

No response

awcodes commented 2 months ago

Try running php artisan filament:assets you might not be serving the updated js file.

AlexisSerneels commented 2 months ago

Hi.

That is the first thing I did. (seeing your other comment)

I’ll send you a reproduction repo in a few days if needed.

awcodes commented 2 months ago

Yes, please send a reproduction repo. That would help.