Closed mbalandis closed 2 months ago
'123' isn't valid content for Tiptap, it either needs to be the tip json schema or valid html, ie: <p>123</p>
'123' isn't valid content for Tiptap, it either needs to be the tip json schema or valid html, ie:
<p>123</p>
Thank you for reply.
I have found a workaround by just encapsulating html tags around text. I am just confused as why "123" is not valid but "123." or "123x" is if both are input as string and it accepts string in helper because <p>123</p>
itself is a string.
It is not ideal and package should be able to handle this as even if I provide "123" as a string it un-casted it back to integer and threw and exception.
My use case is basically trying to get legacy plain text shown in the component tip tap understands and the only time it fails if it is just numbers.
If you insist this is not an issue feel free to close the ticket. p.s might be related: https://github.com/ueberdosis/tiptap/issues/2586 so likely nothing you can do. tiptap has 480 open issues so has lots of bugs.
Quick update: using html tag doesn't help. crashes in console. needed to do something like adding a . to the end.
Can you give me a minimum reproduction repo? If you can then I can investigate further.
@awcodes
Thank you for the help.
I have created a minimal reproduction repo: https://github.com/sharpstream/tiptap-issue-445
I realised that <p>
tags are ok it seems but <span>
aren't though are valid HTML. It is not the issue however the repo will demo the situation. Let me know if you have an issue with the repository. I did not make a seeder as it takes 2s to do it manually. I have provided instructions in the readme.
Use case of this demo is to convert existing plain text entry to rich one.
The issue here is that Tiptap requires a minimum node wrapper of <p>
and <span>
is a mark which can only be inside of a node. Marks can't stand on it's own.
Since this is a requirement of both Tiptap, Tiptap PHP and ProseMIrror, there's nothing I can do about it from the plugin.
My suggestion is that you need to wrap the content during your conversion in at least p tags.
The one thing that is weird to me is that the underlying PHP package thinks that '123' is an int instead of a string. But that is happening in the PHP package and not something I can control from the plugin itself.
Appreciate you checking it out. Yea it makes sense.
Filament Version
v3.2.98
Plugin Version
v3.4.8
PHP Version
PHP 8.3
Problem description
When trying to use helpers:
tiptap_converter()->...
when input is numeric it fails with error:Trying to access array offset on int
and crashes. The value passed in is a string so there is no way to cast it as it gets reverted. This package does read it as "int" regardless.I have encountered this issue when I tried to add a test entry with "description: 123".
Expected behavior
Should not crash and output the expected converted output.
Steps to reproduce
Call any of these:
Reproduction repository
No response
Relevant log output