search

awcodes / overlook

An app overview widget for Filament panels.
MIT License
163 stars 11 forks source link

Update widget.blade.php #12

Closed maaz1n closed 1 year ago

maaz1n commented 1 year ago

Change @svg() to dynamic blade component

Fixes Svg by name "custom-icon-compoent" from set "default" not found. error thrown when custom icons not in blade UI kit is used for navigation icon.

awcodes commented 1 year ago

Any reason you can't register custom svgs as a set in Blade UI kit? Filament v3 will be switching the @svg due to the poor performance of dynamic component based icons. And I tend to agree with the approach.

maaz1n commented 1 year ago

The main reason for making this pr is that custom icons work in filament by default and I would expect the same icon to work with the package as well. But if filament is switching to @svg then I guess it's fine..

awcodes commented 1 year ago

That's a valid point. I'll give it some thought.

awcodes commented 1 year ago

Thanks.