switch to inheriting from StandardError

aweber / AWeber-API-Ruby-Library

DEPRECATED - Ruby interface to AWeber's API.

http://www.aweber.com

BSD 3-Clause "New" or "Revised" License

25 stars 18 forks source link

switch to inheriting from StandardError #40

Closed pcai closed 7 years ago

pcai commented 8 years ago

( fixes #26 )

as extensively documented elsewhere, catching or extending Exception in ruby is a bad practice.

patrickmclaren commented 7 years ago

Anything blocking this to merge?

pjg commented 7 years ago

@amberheilman could you please release a new version of this gem with this change? Having your latest gem version doing rescue Exception is not that great, to be honest.