issues
search
awegroup
/
AWE-Eco
A reference economic model for airborne wind energy systems
MIT License
2
stars
0
forks
source link
Project review
#1
Closed
mwakok
closed
3 weeks ago
mwakok
commented
2 months ago
Some initial observations
[x] Reduce the scope of the global variable and make use of input arguments, containing only the required data:
eco_BoP.m: reduce scope and remove obsolete inputs
eco_Bos.m: reduce scope of
inp
, avoid overwriting
eco
eco_g_station: refactor into separate function to reduce variable scope
[x] Consider using the
switch
statement with
case
for single variable comparison, instead of
if
statements
[x] Does the
eco
data structure make sense for its usage? Could it also be separated in to CAPEX and OPEX?
[x] Move
.gitattributes
to root of repository
[x] Update license information to conform with TUD policy
[x] Is it useful to make use of default input parameters?
[x] Add gitignore (
https://github.com/github/gitignore/blob/main/Global/MATLAB.gitignore
)
Some initial observations
inp, avoid overwritingecoswitchstatement withcasefor single variable comparison, instead ofifstatementsecodata structure make sense for its usage? Could it also be separated in to CAPEX and OPEX?.gitattributesto root of repository