search

aweijun / pe

0 stars 0 forks source link

Link Object Multiplicity seems incorrect [DG] #11

Open aweijun opened 2 years ago

aweijun commented 2 years ago

Current

image.png

image.png

Suggestion

Unlike what is stated in the DG, a empty link object its created if the field is left empty. Therefore, should the multiplicity show 1 instead?

nus-se-bot commented 2 years ago

Team's Response

Internally, we use an empty link object to represent no links rather than using null so that we can avoid NullPointerExceptions. So, it is correct that our UML diagram reflects 0..1

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: ## Explanation

I understand your rational of using an empty link object. However, this doesn't change the problem of that labelling the multiplicity as 0, would no doubt implies that it is possible for the Task class to not be assigned to a Link object at all.

However considering this was never mention within the DG nor was there any disclaimer made in advance, as such this would no doubt lead to misunderstandings, which was why I flagged it out as an issue in the first place.

You informing me of your rationale, that this issue would lead to misunderstanding when developers first look at your UML diagram.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: This would affect the understanding of developers and hence, it would be labelled under severity.Low.