aweiteka / UATFramework

A lightweight User Acceptance Testing framework
GNU General Public License v2.0
3 stars 12 forks source link

Add test scenaro for atomic mount and unmount testing #52

Closed chuanchang closed 9 years ago

chuanchang commented 9 years ago

As subject.

miabbott commented 9 years ago

@chuanchang I have a couple of comments/questions inline, but overall this looks good. Thanks for the additional tests!

chuanchang commented 9 years ago

@miabbott, thanks for your nice comments, the v2 is comming.

miabbott commented 9 years ago

@chuanchang In steps/containers_kube.py, many of the remote_cmd() calls use remote_user=root. Some of these were originally there, while others you have added in your new methods.

Could you test if removing the remote_user argument in your methods will still cause them to work properly?

chuanchang commented 9 years ago

@miabbott, I double checked 'remote_user=root' argument in my real testing work, it's not necessary for testing, so I have removed them from steps/containers_kube.py in my v2 patches.

chuanchang commented 9 years ago

v2 ~ v1

containers_kube: 1. add new functions to get images id
                 2. remove unused remote_user="root" argument

atomic: 1. update codes according previous comments
        2. add new test scenario for {m|unm}ount image to specified directory
miabbott commented 9 years ago

:+1: