search

awelkie / RustFFT

A mixed-radix FFT library written in pure Rust
Apache License 2.0
189 stars 18 forks source link

Better KissFFT benchmarking #3

Closed awelkie closed 9 years ago

awelkie commented 9 years ago

The KissFFT Rust library that the benchmarking code depends on does not compile with optimizations, so the benchmarks aren't very valid.

The KissFFT library should build with optimizations, or (better yet) the benchmarking code should just link against KissFFT, and the user can build KissFFT however they like.

m13253 commented 9 years ago

I am the author if KissFFT binding.

I just added -O3 in build.rs. Maybe there is a better solution (manual linking or gcc crate or something), but I will just wait and see if it suits.

And thank you.

awelkie commented 9 years ago

Awesome, thanks! I think the best solution is to use the links keyword in your manifest, and to use the gcc crate. This will let users control the optimization level and compiler when building KissFFT, or let them link against their own binaries. But since Cargo doesn't actually pass the compiler options down to the build script yet, and your build script already handles most of this functionality, this is the better solution for now.

This solves the biggest issue with benchmarking, so I'll mark this issue as solved.