search

aweris / gale

GitHub Action Local Executor
Apache License 2.0
142 stars 4 forks source link

How does gale handle dagger version differences when used via the dagger CLI? #84

Closed gerhard closed 8 months ago

gerhard commented 10 months ago

When gale is run via the dagger CLI, how does it ensure compatibility with the Engine that dagger manages?

As you know, when a command is run via dagger run <YOUR_COMMAND HERE>, the dagger CLI provisions the Engine. So if I have dagger v0.8.4 running locally which provisions Engine v0.8.4, but gale v0.0.4 expects v0.8.1, could this cause issues?

🙇‍♂️ For the dagger run gif size issue, have you tried dagger run --progress plain ? cc @vito for more terminal recording & sharing tips.

aweris commented 10 months ago

🙇‍♂️ For the dagger run gif size issue, have you tried dagger run --progress plain ? cc @vito for more terminal recording & sharing tips.

Found the issue. terminalizer automatically gets screen size. If I don't drop my resolution to a minimum or adjust the screen size, it tries to generate bigger images. Adjusting the resolution helped a lot.

aweris commented 8 months ago

With new module structure, no need to handle this issue specifically