Frame color for Views - Githubissues

awesome-gocui / gocui

Minimalist Go package aimed at creating Console User Interfaces.

BSD 3-Clause "New" or "Revised" License

344 stars 39 forks source link

Frame color for Views #71

Closed dankox closed 3 years ago

dankox commented 3 years ago

Hi, I wanted to ask, if I could create a PR for adding frame color for seperate views. Basically it would add new color attribute to view for frame and title color.

I had created a fork with that change which I'm using in my project. But I was hoping something like that could be added to this repo too.

Here is my commit in the forked repo: https://github.com/dankox/gocui/commit/a7e8d20a79e69a488327eaaeeeb8ce0c62d67e3c

mjarkk commented 3 years ago

Seems like an oke change to me.
Feel free to create a PR for this!

glvr182 commented 3 years ago

sounds good! go for it!

dankox commented 3 years ago

Cool. I created a PR, but I added there a bit more. It's still related to the frames, so I hope you won't mind. If you feel like the added customization is not ok, I can revert it to color customization only.