search

awesome-inc / FontAwesome.Sharp

A library for using Font Awesome in WPF & Windows Forms applications
Apache License 2.0
376 stars 87 forks source link

Update NuGet package FontAwesome.Sharp.Pro #114

Closed RickMannien closed 10 months ago

RickMannien commented 1 year ago

Like mentioned in Issue #112 the changes of Pull Request #108 still are not present in the current NuGet package. Could you please have a second look and update the NuGet package?

mkoertgen commented 11 months ago

@RickMannien Sorry for responding late.

Changes have been merged and package pushed 5 months ago

How did you conclude changes are not present in the package?

RickMannien commented 11 months ago

No worries let me elaborate a bit more,

I get the exact same error as described in the orignal issue when using the NuGet packages. So I decided to pull from main and check whether or not the changes are present there. I found that the changes to fix the pro package are not present. So I'm assuming that they also never made it to the NuGet package.

The changes can be found here: https://github.com/awesome-inc/FontAwesome.Sharp/pull/108/files. I'm focussing on the changes in

Where the type IconFont is changed to ProIconFont

I added these changes myself in a local version of the package which resolves the error for me.

Please tell me if I'm making a mistake somewhere, but I hope this helps

mkoertgen commented 10 months ago

I see, the pull request has been merged to the pro branch

mkoertgen commented 10 months ago

Merged main + pro branches, updated to 6.4.2

mkoertgen commented 10 months ago

Should be fixed with the 6.4.2 update:-

nj commented 2 months ago

@mkoertgen Assume you went a big quick in making this as completed, as the build end up failing, due to a bug in the main at that time.

It states 10 errors and 13 warnings, so was never updated on NuGet 😞

Can it be rerun, perhaps bump version ?

Also made a PR #120, to reflect latest FA, so it can be included at the same time.

Thanks!