search

awesome-inc / FontAwesome.Sharp

A library for using Font Awesome in WPF & Windows Forms applications
Apache License 2.0
385 stars 89 forks source link

overloading ToBitmap with width/height params #25

Closed dbhc closed 4 years ago

dbhc commented 4 years ago

FormsIconHelper's ToBitmap method only accepts a single size param. For underlying fonts that are much wider than tall (or vice versa), it creates a much smaller image than intended. Exposing a way to explicitly set the width and height would be helpful.

I created a fork with this change if you'd like to merge it.

mkoertgen commented 4 years ago

@dbhc I would love to merge it in. I created a pull request for it #26. Out of curiosity: which font did you try?

dbhc commented 4 years ago

Cogs, UserCog, MoneyCheckAlt to name a few. MoneyCheckAlt was the one that had the greatest width to height aspect ratio.

mkoertgen commented 4 years ago

Ah, i see. It was in fact some icons with a non-square aspect ratio. Ok, thanks.

mkoertgen commented 4 years ago

Merged with #26