search

awesome-inc / FontAwesome.Sharp

A library for using Font Awesome in WPF & Windows Forms applications
Apache License 2.0
385 stars 89 forks source link

[=] Fixed icons cache and optimizations in icon picture box #7

Closed VoidVolker closed 6 years ago

VoidVolker commented 6 years ago

IconsCache -> static class, added dispose support IconPictureBox - removed some useless code, added some optimizations

VoidVolker commented 6 years ago

@mkoertgen sorry, I reverted some parts of your changes and cleanup - because was far away from internet and wasn't able to download them. I hope you used some automatic tool for this :)

mkoertgen commented 6 years ago

No prob. Most of it was in deed automated.

VoidVolker commented 6 years ago

Ok, good. Any feedback or questions about code? What next? Shall I add some any new code or fix something?

mkoertgen commented 6 years ago

All good. I'll review the code and re-run ReSharper code cleanup. If any questions come up i will ask them here.

Maybe we should conclude on adding rotate/flip support also for the other controls. Would be glad if you could pick up on that (if you have time). Be sure to start from current develop before you start, if so.

Finally let's merge to master and publish the new version. Expect that to happen in a few days.

VoidVolker commented 6 years ago

Ok, I'll add rotate/flip for other controls.