search

awesome-kyuubi / hadoop-testing

Testing Sandbox for Hadoop Ecosystem Components
Apache License 2.0
32 stars 13 forks source link

#42 Remove copied files for building images #46

Closed yanghua closed 9 months ago

yanghua commented 9 months ago

Close #42

yanghua commented 9 months ago

@pan3793 I have tested. It seems everything is OK.

pan3793 commented 8 months ago

FYI. I found this change actually has side effects, it corrupts the docker build cache mechanism.

before this change, performing ./build-image.sh and again, the second time docker build hit the cache, but after this change, not.

To be clear, I'm fine with either keeping it or reverting it.

yanghua commented 8 months ago

FYI. I found this change actually has side effects, it corrupts the docker build cache mechanism.

before this change, performing ./build-image.sh and again, the second time docker build hit the cache, but after this change, not.

To be clear, I'm fine with either keeping it or reverting it.

Do not know why this behavior causes miss cache. Every time, running ./build-image.sh, the cp command still prepare the previous files before building images just like we do not remove them.

pan3793 commented 8 months ago

because the inode changed? not sure.