Move from begin/rescue/end (BRE) to RSpec metadata when running adapters specs

awesome-print / awesome_print

Pretty print your Ruby objects with style -- in full color and with proper indentation

http://github.com/michaeldv/awesome_print

MIT License

4.08k stars 454 forks source link

Move from begin/rescue/end (BRE) to RSpec metadata when running adapters specs #175

Closed maurogeorge closed 9 years ago

imajes commented 9 years ago

OK, this looks good but you've mixed in whitespace/formatting changes with actual functional changes. Do you think we can run a separate branch first which does the whitespace change, so that we can get clean commits?

thanks!

maurogeorge commented 9 years ago

@imajes I guess I do not touch formatting, the whitespace I create a PR to remove some maybe I miss some.

I guess it is hard to see the changes because I usualy remove a full ident of code, because I removed the BRE. I think the better way to you review is clicking the "view" button on each file under the "Files Changed" tab on top.

imajes commented 9 years ago

Yeah, i guess the BRE really did screw with the indentation. It's frustrating because that change kinda gets lost in the noise of the re-indent. I think we'll just have to accept it. i'll merge this in a bit.

imajes commented 9 years ago

Done. merged via rebase. good work!