search

awesome-print / awesome_print

Pretty print your Ruby objects with style -- in full color and with proper indentation
http://github.com/michaeldv/awesome_print
MIT License
4.08k stars 454 forks source link

Clean up old Rubies and Rails #189

Open maurogeorge opened 9 years ago

maurogeorge commented 9 years ago

clean up the code to get rid of Ruby 1.8.x-only hacks. I think by now it's safe to drop support for 1.9.3 as well and focus on Ruby v2.x only. I think we can certainly drop Rails v2 but I'm not so sure about dropping Rails v3.

Created based on the idea of @michaeldv about the future of the project

imajes commented 9 years ago

Yeah i think that's a good idea. makes sense to signpost on README that the current release is the last one that supports 1.8x and Rails 2x.

gerrywastaken commented 8 years ago

Sounds good to me.

@waldyr How do you feel about us dropping support for anything below Ruby 2.0?

We are already running into build issues on Travis every time somebody drops support in their gem resulting in the addition of many gem <old version goes here>, :platforms => :ruby_19 lines to our Appraisals file. https://github.com/awesome-print/awesome_print/blob/master/Appraisals

Just yesterday the json gem's dropped support for old rubies resulted in failed builds: https://github.com/awesome-print/awesome_print/pull/255

I suggest officially dropping support for 1.9 after the next release and removing/updating redundant code as convenient in a piecemeal fashion.

waldyr commented 8 years ago

I agree with that. 👍

gerrywastaken commented 8 years ago

@waldyr Cheers

waldyr commented 8 years ago

Also this is one thing @michaeldv pointed out it should be done :)