search

awesome-print / awesome_print

Pretty print your Ruby objects with style -- in full color and with proper indentation
http://github.com/michaeldv/awesome_print
MIT License
4.07k stars 454 forks source link

Make option name more meaningful #258

Closed gerrywastaken closed 8 years ago

gerrywastaken commented 8 years ago

@waldyr: @alexch and @imajes raised some good points about the naming of the new_hash_syntax option (https://github.com/awesome-print/awesome_print/pull/193/commits/188becfadfbff3b5fd952e0366bf36c8c6f59b59#r26746035). I only just spotted these comments and I think they raise good points. So I propose ruby19_syntax as the symbol name. Glad I spotted this before we released.

Commit message:

I just noticed a code review which suggested against the name we are currently using and gave some good reasoning:

"Naming things "new" is always a problem (since time passes and it's no longer new). Maybe colonize_symbol_keys? ("colonize" sounds kind of gross though...) https://git.io/vKIiX

The ruby19_syntax name was suggested later in the conversation.

As we have not yet released with the previous option name, it's now or never for this change.

waldyr commented 8 years ago

I was wondering what would be the best name for it and I end up sticking with what we had. This is definitely better.

LGTM