search

awesome-print / awesome_print

Pretty print your Ruby objects with style -- in full color and with proper indentation
http://github.com/michaeldv/awesome_print
MIT License
4.07k stars 454 forks source link

Improve code climate #279

Open gerrywastaken opened 7 years ago

gerrywastaken commented 7 years ago

I changed code climate config while ago to respect our .rubocop config and also start linting with Reek.

https://github.com/awesome-print/awesome_print/pull/254

This lead to our Code Climate score dropping dramatically (which was expected). I was waiting for time when there would be minimal PRs affected by refactoring before addressing many of the issues that Code Climate addressed. There are still a few PRs which are partially completed, however updating them should be trivial so long as changes made in this issue are split up correct.

gerrywastaken commented 7 years ago

@waldyr I'm wondering what your thoughts are regarding these two PRs? https://github.com/awesome-print/awesome_print/pull/246 https://github.com/awesome-print/awesome_print/pull/247

I understand all too well that life can be busy, but I'm thinking about refactoring those files and I'm not sure if you are planning on continuing your work? I don't wish to step on your toes but I'm keen to know how you feel in regard to those PRs. Feel free to speak bluntly.