Closed jamespdo closed 7 years ago
@gerrywastaken Any chance we can merge this PR?
I also get warning without #293 patch.
My environment is as follows:
$ ruby -v
ruby 2.4.0p0 (2016-12-24 revision 57164) [x86_64-darwin14]
$ gem list awesome_print
*** LOCAL GEMS ***
awesome_print (1.7.0)
Warning has occurred as follows:
$ irb
irb(main):001:0> require 'awesome_print'
=> true
irb(main):002:0> ap 123
123
=> nil
irb(main):003:0> ap [123]
/Users/murakami/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/awesome_print-1.7.0/lib/awesome_print/formatters/base_formatter.rb:31: warning: constant ::Fixnum is deprecated
[
[0] 123
]
=> nil
irb(main):004:0>
Here is related news.
Feature #12005: Unify Fixnum and Bignum into Integer - Ruby trunk - Ruby Issue Tracking System https://bugs.ruby-lang.org/issues/12005
Thanks @jamespdo I'll need to figure out the build issue first then I can merge. Cheers for this. :) cc: @irobayna.
@murakamit I'm not sure what you are saying here. Indeed this pull request solves a problem. If you do not apply it, if the fix is not applied it is expected you will still have the issue. I might be misunderstanding you.
Associated issue: https://github.com/awesome-print/awesome_print/issues/299
Merged, cheers for the fix. :)
This is still in place in the currently published gem (1.7.0) is there going to be a new release or should we be pointing to master
when installing this gem?
@gerrywastaken can you release new version which include this merge? or release 1.7.1 to patch if its not ready?
Since the Ruby-2.4.0 release, Fixnum and Bignum are combined into Integer class. This fix is to remove all Fixnum reference.