search

awesome-print / awesome_print

Pretty print your Ruby objects with style -- in full color and with proper indentation
http://github.com/michaeldv/awesome_print
MIT License
4.07k stars 454 forks source link

Fix method signature after change in IRB #390

Closed febeling closed 3 years ago

febeling commented 3 years ago

We override IRB::Irb::output_value in awesome_print/custom_defaults.rb.

IRB Introduced a default argument for this method in https://github.com/ruby/irb/commit/c5ea79d5cecea9cae6ad0c1f31703a98cd329431. When overriding this changed signature an ArgumentError is raised.

To fix, we capture any parameters. They are discarded anyway in our case.

Closes #389

febeling commented 3 years ago

The build failure is some conditional check for old versions which is off base imo.

See https://travis-ci.org/github/awesome-print/awesome_print/jobs/747933000#L370

febeling commented 3 years ago

amazing-print/amazing_print#57 contains this exact change; no need to duplicate here.

letiesperon commented 3 years ago

Anxiously waiting for this to be released 😂 @febeling

BryanH commented 3 years ago

@letiesperon Done! Have a few more to work through and then will see about releasing a new version!