search

awesome-webextension / webpack-target-webextension

WebExtension Target for Webpack 5. Supports code-splitting and HMR.
MIT License
46 stars 5 forks source link

Add failing CSS part to HMR demo #31

Closed fregante closed 2 years ago

fregante commented 2 years ago

Follows https://github.com/awesome-webextension/webpack-target-webextension/issues/29

It seems that the error manifests even with the basic CSS extraction configuration, but only in serve mode; webpack build works correctly.

This might not be a bug of this plugin

Jack-Works commented 2 years ago

Ok, so I'll try to fix the problem with the CSS extractor/loader. But maybe it's not a bug within this project and I may not start the work right now. Maybe a few days I'll come back.

Jack-Works commented 2 years ago

😭 Sorry for the delay but I still don't have time to investigate this problem. I have a deadline today! But I promise this issue is on my TODO list for a long time

fregante commented 2 years ago

No worries, same here, I haven't had time to test your examples PR either 😅

Jack-Works commented 2 years ago

well, it works, but by a very unwanted patch.

Jack-Works commented 2 years ago

It's very hacky, and the example also need rewrite

Jack-Works commented 2 years ago

cc @fregante @crimx plz review this

fregante commented 2 years ago

Tested, it works! Thank you for the help