awesomeWM / awesome-www

Website of AwesomeWM
https://awesomewm.org/
56 stars 34 forks source link

chore: switch from travis to gh actions (fixes #169) #170

Closed actionless closed 2 years ago

Elv13 commented 2 years ago

Huge thanks for this. Do you want to merge that already and iterate with new PRs for the fixes or want to play whack a mole for a few iterations?

aajjbb commented 2 years ago

Should this also include a change in README.md to remove the travis reference?

Elv13 commented 2 years ago

The issue is more that Travis removed itself. They switched off all open source projects free accounts once they consumed some "credits". I paid for the commercial version for 6months until amazing people helped to move the main repo to GitHub actions. I knew when I stopped paying it would break the -www repo, but it wasn't worth paying 1000$US a year for this repo alone.

actionless commented 2 years ago

i think it's ready now

actionless commented 2 years ago

now gon be the most interesting part 😹

actionless commented 2 years ago

apparently it needs token to be set in secrets?

https://github.com/awesomeWM/awesome-www/runs/7063206869?check_suite_focus=true#step:14:691

actionless commented 2 years ago

and also it doesn't show the commit range correctly🙁 : https://github.com/awesomeWM/awesome-www/runs/7063206869?check_suite_focus=true#step:14:35

Elv13 commented 2 years ago

I gave you the rights to manage the secrets for -www, you should be able to set them now

actionless commented 2 years ago

no, i don't (neither for /awesome/ repo itself)

Elv13 commented 2 years ago

you really should. Maybe it sent you an email with an invite link?

image

Elv13 commented 2 years ago

Anyway, if for whatever reason its broken, give me instructions and I will try to set them.

actionless commented 2 years ago

now i can see the secrets for www repo, but not for the main one

i need to copy the same secret from https://github.com/awesomeWM/awesome/settings/secrets/actions to https://github.com/awesomeWM/awesome-www/settings/secrets/actions

actionless commented 2 years ago

(i guess key itself should be somewhere in the settings of this repo, but i can't view them neither: https://github.com/awesomeWM/awesomeWM.github.io)

Elv13 commented 2 years ago

The AWESOME_ROBOT_TOKEN secret?

actionless commented 2 years ago

yup

actionless commented 2 years ago

the key i think should be at https://github.com/awesomeWM/awesomeWM.github.io/settings/keys

Elv13 commented 2 years ago

@blueyed Can you add it to -www. I can change it, but I can't view it.

actionless commented 2 years ago

i think you can just add a new key there as well if you can't view existing one: https://github.com/awesomeWM/awesomeWM.github.io/settings/keys

Elv13 commented 2 years ago

I think it in a normal github account, not the project one ( https://github.com/awesome-robot ). I don't control that account. Let's wait a couple days and see if Daniel replies.

actionless commented 2 years ago

no, i mean you can use just a deployment key frmo there: https://github.com/awesomeWM/awesomeWM.github.io/settings/keys

actionless commented 2 years ago

(with write access)

Elv13 commented 2 years ago

Right now there isn't any. I am pretty sure it was just using the robot account so far. Is it worth changing that?

actionless commented 2 years ago

i think it shouldn't be much difference - as you sharing that token only with github, not with some additional third-parties like travis

Elv13 commented 2 years ago

Ok, go ahead, I made you admin of awesomeWM.github.io

actionless commented 2 years ago

my bad, i tried - it allowing to generate only ssh key but not the token :(

actionless commented 2 years ago

i could generate a token from my own account in order just to test all ci step work

actionless commented 2 years ago

(and after testing remove the token and wait next for @blueyed to put the correct token instead of it)

Elv13 commented 2 years ago

As a temporary solution maybe. Long term we need to find a way to manage the robot account in a way that doesn't involve a single point of failure.

But right now, getting -www to work again is worth a few hacks. It being broken is a rather big problem and I am glad you are taking upon fixing that, so go ahead.

actionless commented 2 years ago

now it works (i removed my personal token, so it just empty string now)

also somebody would need to set: $CLOUDFLARE_ZONE $CLOUDFLARE_AUTH_EMAIL $CLOUDFLARE_AUTH_KEY